[k2] rpc client API by T-y-c-o-o-n · Pull Request #1635 · VKCOM/kphp

T-y-c-o-o-n · 2026-06-15T10:37:24Z

No description provided.

apolyakov · 2026-07-21T09:50:54Z

+  kphp::coro::io_scheduler& m_scheduler{kphp::coro::io_scheduler::get()};
+  std::chrono::nanoseconds timeout{kphp::time::remaining(deadline)};
+
+  co_await m_scheduler.poll(rpc_d, kphp::coro::poll_op::read, timeout);


Looks like it's possible for timeout to become zero or negative here. Please, read io_scheduler::poll documentation for timeout

Yeap, handled timeout <= 0 case manually

apolyakov · 2026-07-21T09:52:50Z

+    }
+  }
+
+  kphp::coro::task<void> wait_for_response() noexcept;


Let's take one more step if you started splitting declarations and definitions:

let's have query_handle's body only include declarations with doc comments

let's have all implementation defined out-of-class

Done. Only constructors, destructor and assign operators have definition inside class

apolyakov · 2026-07-21T09:54:22Z

+  }
+}
+
+std::expected<query_handle, int32_t> send_and_get_handle(std::string_view actor, bool collect_responses_extra_info, bool ignore_answer,


nit: why not just send? Do we really need to highlight that we get handle as a return value?

I don't understand why do we need this function at all. It seems like it's literally part of kphp::rpc::send_request

Renamed it with send

I've moved logic about regularize_extra_headers and collect_response_extra to kphp::rpc::send_request, and leaved here only logic about creating query. That allowed me to avoid rpc_query_handle.cpp file

apolyakov · 2026-07-21T09:59:55Z

+    if (it_rpc_request_handle == rpc_client_instance_st.rpc_query_handles.end()) [[unlikely]] {
+      co_return request_id;
+    }
+    // FIXME after response fetch finished `it_rpc_request_handle` will become invalid iterator


So, let's fix this :)

WE discussed, that wait_for_response may await inside and overlife object destruction, but this is not a problem, because after wait it does not touch object fields

apolyakov · 2026-07-21T10:00:28Z

+  k2::instant(std::addressof(now_instant));
+
+  std::chrono::nanoseconds now_ns{now_instant.time_point_ns};
+  std::chrono::nanoseconds deadline_ns{duration_cast<std::chrono::nanoseconds>(deadline)};


What is duration_cast here?

It looks like you use duration as time point. Please, correct me if I'm wrong

You'r right. Replaced deadlines types with std::chrono::steady_clock::time_point

apolyakov · 2026-07-22T14:49:48Z

+
+namespace kphp::rpc {
+
+inline constexpr std::string_view EMPTY_QUERY_ERROR_DESCRIPTION = "fetching rpc response from empty query";


Do we need this? Isn't it enough to return an error code?

laeved only rpc error code

apolyakov · 2026-07-22T14:50:06Z

+
+class query_handle {
+  k2::descriptor m_descriptor{k2::INVALID_PLATFORM_DESCRIPTOR};
+  std::chrono::steady_clock::time_point m_deadline{};


nit: no need for explicit init here

…GAIN` errno if response is not ready

…e std::string_view instead of string, removed m_id from query_handle

…nse()

…ator

…sponse_awaiter_tasks

…:STATIC_BUFFER_LENGTH`; added `if collect_responses_extra_info` check

T-y-c-o-o-n force-pushed the n.siniachenko/k2/rpc-client-boost branch from 156e9ec to 222adae Compare June 15, 2026 11:57

T-y-c-o-o-n commented Jun 17, 2026

View reviewed changes

Comment thread runtime-light/stdlib/rpc/rpc-api.cpp

Comment thread runtime-light/stdlib/rpc/rpc-queue-functions.h Outdated

apolyakov requested changes Jun 18, 2026

View reviewed changes

T-y-c-o-o-n force-pushed the n.siniachenko/k2/rpc-client-boost branch from a342aa9 to e77636c Compare June 21, 2026 19:19

apolyakov reviewed Jun 29, 2026

View reviewed changes

Comment thread runtime-light/k2-platform/k2-header.h Outdated

Comment thread runtime-light/k2-platform/k2-api.h Outdated

Comment thread runtime-light/stdlib/time/util.h Outdated

T-y-c-o-o-n force-pushed the n.siniachenko/k2/rpc-client-boost branch 2 times, most recently from 0c1f4cc to 44d348e Compare July 17, 2026 13:14

apolyakov requested changes Jul 21, 2026

View reviewed changes

T-y-c-o-o-n changed the title ~~[k2] rpc client boost~~ [k2] rpc client API Jul 22, 2026

apolyakov reviewed Jul 22, 2026

View reviewed changes

Nikita Siniachenko added 20 commits July 24, 2026 18:47

first impl

bf39efd

added kphp rpc client bench

9daec6b

break in switch + different debug exit codes

cbdbae8

null timeout in bench

b68b51b

rpc send functions now common functions instead of coroutines

7cbcb7c

remove one coroutine on rpc response fetch

c609910

removed test trash

19e0065

error handling

1d38897

rpc_queue_push

4f8b439

kphp::rpc::request_info

31555bf

fmt

2340e15

added RpcKind + better docs

dbc67fd

query_handle

d5353ae

send_and_get_handle

0f1c8e2

refactored query_handle a bit

896ba9c

refactorrr

496db0f

k2_rpc_get_response_size() and k2_rpc_fetch_response() now return `EA…

f219b9e

…GAIN` errno if response is not ready

[EXPERIMENTAL] removed ignore_answer_coroutine

68e2711

regularize_extra_headers

1dad070

added query_handle::wait_for_response

0ca689d

Nikita Siniachenko added 20 commits July 24, 2026 18:48

fixed zeroing query_handle in rpc_queue_push(..)

5d0f66b

insert ignore_answer requests to rpc_query_handles

44c20e3

issues

fd9c00a

fmt

cc232f0

fmt

5c6e40d

refactored kphp::rpc::query_handle

e21663b

removed rpc-query-handle.cpp

222c87b

fixed nullptr request_buffer, fixed <=0 timeout handling, error becam…

e812bfe

…e std::string_view instead of string, removed m_id from query_handle

query_handle: response type now std::span<std::byte>

f2a9369

time utils fixes

a70b830

fmt

4576a4a

fmt

99d7de1

query_handle -> query; removed error description for query::get_respo…

89b6bc6

…nse()

kphp::rpc::query::get_ready_response() takes templated response_alloc…

91ab571

…ator

TODO

0788026

ResponseAllocator and ResponseDeleter

f957b0b

ResponseBufferProvider; removed query::wait_for_response; returned re…

0adcd48

…sponse_awaiter_tasks

request_buffer is allocated for requests more than `StringLibContext:…

47f98cb

…:STATIC_BUFFER_LENGTH`; added `if collect_responses_extra_info` check

fmt

fcf22b8

fmt

6435238

T-y-c-o-o-n force-pushed the n.siniachenko/k2/rpc-client-boost branch from df743db to 6435238 Compare July 24, 2026 15:48

Nikita Siniachenko added 2 commits July 24, 2026 19:33

fmt

d0c69df

k2_rpc_fetch_response may return ENOBUFS

bb2047b


		namespace kphp::rpc {

		inline constexpr std::string_view EMPTY_QUERY_ERROR_DESCRIPTION = "fetching rpc response from empty query";

Uh oh!

Conversation

T-y-c-o-o-n commented Jun 15, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

T-y-c-o-o-n Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

T-y-c-o-o-n Jul 22, 2026 •

edited

Loading