Refine double-click navigation while debugging#1139
Open
xusheng6 wants to merge 2 commits into
Open
Conversation
…ction OnTokenDoubleClicked opened every address-literal token (integer, possible address, code-relative) in a separate pane while debugging. When the target falls inside the function the user is already viewing, they most likely want to jump to it in place, so fall through to the default in-pane navigation in that case and only open a second pane for out-of-function targets. Closes #1136 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
OnTokenDoubleClicked ignored data symbol tokens (e.g. data_100003fa9) and inline string tokens, so they fell through to the default in-pane navigation. While a debug session is live, resolve the referenced address and open it in another pane instead, so the disassembly the user is looking at stays put. Closes #1137 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
Author
|
Just wish to mention -- I somehow think that this should actually become the default behavior when the user is not debugging, or at least an option that can be enabled |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes to
OnTokenDoubleClicked:data_100003fa9) and inline string tokens now open in another pane while debugging, instead of falling through to default in-pane navigation.Closes #1136
Closes #1137
🤖 Generated with Claude Code