Skip to content

Update validation in CurationWriter to use short_form for unrestricte… #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Robbie1977 merged 1 commit into from
Nov 4, 2025
Merged

Update validation in CurationWriter to use short_form for unrestricte… #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/vfb/curation/curation_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,12 +278,13 @@ def write_rows(self, verbose=False, start='100000', allow_duplicates=False):
if verbose:
print(f" ✗ {entity_name}: {yaml_value} not in class_lookup (will fail per-row)")
else:
# Fields without restriction: validate by label directly (e.g., DataSet)
# These are passed as-is to add_anatomy_image_set()
# Fields without restriction: validate by short_form (e.g., DataSet)
# These are passed as short_forms to add_anatomy_image_set()
# add_anatomy_image_set() defaults to match_on='short_form'
self.pattern_writer.ec.roll_entity_check(
labels=labels,
query=yaml_value,
match_on='label'
match_on='short_form'
)

# Check if it exists - only cache if validation succeeds
Expand Down