to main#242
Merged
Merged
Conversation
Root cause: mongoose 9.x removed findByIdAndRemove entirely (Model and Query), but lib/facade.ts still called it — every deleteById threw synchronously. handleImage() swallowed that (and any other) rejection and returned the message string instead of rethrowing, so removeImage's own catch never fired: no socketError was ever sent, and a bogus imageDeleted got published with the error text as its payload. Delete looked like a no-op from the client. - facade.ts: findByIdAndRemove() now calls the model's findByIdAndDelete (mongoose 9.x-compatible), keeping its own external method name so Controller/GigController/JamPicsController are untouched. - AgController.handleImage(): rethrows on failure instead of swallowing, so newImage/removeImage's existing catch blocks (which already transmit socketError) actually get exercised, and a fake imageCreated/imageDeleted no longer gets published on failure. See WebJamApps/JaMmusic#1199. Bumps 3.0.7 -> 3.0.8. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Update mongoose dependency from ^9.6.1 to ^9.7.4 and refresh lockfile. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
…e-error Fix jamPics/gig deletes silently no-oping (root cause of JaMmusic#1199)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.