News Site Next#426
Closed
flashdesignory wants to merge 10 commits into
Closed
Conversation
camillobruni
approved these changes
Sep 2, 2024
camillobruni
left a comment
camillobruni
left a comment
Contributor
There was a problem hiding this comment.
Generally LGTM: might be worth adding a little test to check for consistency across languages and uniqueness of IDs within a language.
Contributor
Author
|
yes, absolutely! |
julienw
approved these changes
Sep 2, 2024
julienw
left a comment
julienw
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me, thanks for the fix.
One more thing: in section.jsx you can use article.id instead of concatenating the section id with index.
Member
|
Do we have before/after numbers? |
Contributor
Author
here's a snapshot
|
Member
|
Is that runtime or pts? |
Contributor
Author
we're displaying runtime in the detail screen, right? |
Contributor
Author
|
@rniwa - any concerns to merge this? |
Contributor
Author
|
closing in favor of: #447 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes next.js issue: #422
A separate pr for Nuxt will do the same.
The fix here is to add unique ids to any article content that is a list.
This is done in the actual data files, so no need for the app to generate them at any point.
@kara