Preserve callee call-site columns and spans (#4841) - #4934
Merged
Conversation
Widthdom
marked this pull request as ready for review
July 27, 2026 15:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reference_countRoot cause
calleesaggregated away the reference column and reconstructed no physical span. Output adapters therefore fell back to the start of the line, while normalized reference identities could not reliably recover the source token width.Validation
dotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=false— 0 warnings, 0 errorsgit diff --checkpassedReview
Two required Codex adversarial-review rounds were completed. The first found resolved constructor names were being used as source widths; the second found method-group/JVM coordinate normalization and hook-clone propagation gaps. All findings were addressed with regressions.
Documentation and changelog
changelog.d/unreleased/4841.fixed.md, referencing the related historical work in Persist precise symbol/reference spans for LSP and editor formats #4417Fixes #4841