Improve wording in TWL portal interface (T430924)

[priyankar1434]

Description

Improves several small text labels on the TWL portal interface based on user feedback in the linked ticket:

1. Clarified that "My Library" refers to a page name in the approval notification emails (added "page").
2. Changed the partner filter label "Multi-step access" to "Access upon application" for clarity.
3. Changed the partner filter label "Searchable" to "Indexed in the Library's search engine" to clarify it refers to the global search engine, not individual partner sites.
4. Changed the "Filter collections" search placeholder to "Search the collection descriptions" to clarify what field is being searched.
5. Simplified the renewal status message on the My Applications page to avoid repeating the word "renewal" twice.

Rationale

These changes were suggested by a user in the linked Phabricator ticket, who noted that several small text labels on the portal were unclear or ambiguous. The new wording aims to make these labels more self-explanatory for both new and existing users.

Phabricator Ticket

https://phabricator.wikimedia.org/T430924

How Has This Been Tested?

This is a text-only change. Each string was located in the codebase and verified against the surrounding context (filters, templates, email notifications) to confirm it matches the intended display location. No functional/logic changes were made.

Screenshots of your changes (if appropriate):

N/A - text/wording only changes

Types of changes

What types of changes does your code introduce? Add an x in all the boxes that apply:

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Minor change (fix a typo, add a translation tag, add section to README, etc.)

[priyankar1434]

Hi @theresnotime , i noticed the cicd check failed again on test_merge_partner_suggestion_view_post after your re-run. this test checks suggestion merge upvote counts, which seems unrelated to this PR's wording-only changes. is this a known/pre-existing flaky test, or could it be related to something else? Happy to investigate further if needed.

[theresnotime]

Hi @theresnotime , i noticed the cicd check failed again on test_merge_partner_suggestion_view_post after your re-run. this test checks suggestion merge upvote counts, which seems unrelated to this PR's wording-only changes. is this a known/pre-existing flaky test, or could it be related to something else? Happy to investigate further if needed.

I'm not sure if this is a known flaky test, but I've re-run the CI and we'll see if it fails again :)

[theresnotime]

Passed on a re-run - I've logged this as a potentially flaky test at https://phabricator.wikimedia.org/T431407. Thank you!

[priyankar1434]

@theresnotime thanks for confirming and logging that! since all checks are passing now, is there anything else needed from my side, or is this ready to be reviewed/merged?

[theresnotime]

@theresnotime thanks for confirming and logging that! since all checks are passing now, is there anything else needed from my side, or is this ready to be reviewed/merged?

I've added it to our board for code review requests - someone should take a look soon :)

[Samwalton9]

Closing in favour of the existing (and updated) #1537