chore: add PR template and required CI checks (V2-719, V2-720)#12
Open
jacderida wants to merge 1 commit into
Open
chore: add PR template and required CI checks (V2-719, V2-720)#12jacderida wants to merge 1 commit into
jacderida wants to merge 1 commit into
Conversation
Add the standard pull request template (V2-719) and the CI enforcement that makes a linked Linear issue and the template fields required on every PR (V2-720). Part of the release-process extensions; identical across the six crate repos. - .github/PULL_REQUEST_TEMPLATE.md: eight-field template with Risk tier and Semver impact checkboxes, stable headings as grep anchors for the train-manifest verification. - agent instruction files (CLAUDE.md / AGENTS.md): instruct agents to fill the template on PR open. - .github/workflows/pr-checks.yml + .github/scripts/check_pr.py: the linear-link (main + rc-*) and pr-template (main) required status checks. V2-719 V2-720 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear issue
Risk tier
Compatibility
Semver impact
Test evidence
check_pr.pywas exercised locally across its cases: missing Linear referencefails
linear; a key in the title/body/branch passes; a body without thetemplate fails
template; an rc-* base is a no-op pass; a fully-filled templatepasses; and the failure modes (no/duplicate tier or semver box, empty section,
Tier 2/3 without an ADR link) each fail with a specific message. This PR's own
description is validated by the new checks.
New dependency
none
ADR
n/a
Mitigation / rollback
Revert this PR; the template and checks are additive and carry no runtime effect.