[TASK][TRAC-13103] Check DB_CHARSET before installing WP Core#12087
[TASK][TRAC-13103] Check DB_CHARSET before installing WP Core#12087ramonfincken wants to merge 3 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @ramon@creativepulses.nl, @ramon-fincken@chat.wordpress.org. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
mukeshpanchal27
left a comment
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks @ramonfincken for the PR!
Let some initial feedbacks
| $mysql_version = $wpdb->db_version(); | ||
| $php_compat = version_compare( $php_version, $required_php_version, '>=' ); | ||
| $mysql_compat = version_compare( $mysql_version, $required_mysql_version, '>=' ) || file_exists( WP_CONTENT_DIR . '/db.php' ); | ||
| $mysql_db_charset_compat = true; |
There was a problem hiding this comment.
make sure to align equal signs
There was a problem hiding this comment.
it will place all others much more to the right, using spaces ...
There was a problem hiding this comment.
I can hower change to compat so -> if isset compat and compat -> then ...
2 participants
Trac ticket: https://core.trac.wordpress.org/ticket/13103
This will check the DB_CHARSET compatibility upon installing, preventing a non-supported (defined) DB_CHARSET to be used in DB installer.
Based on 13103.patch (816 bytes) - added by SergeyBiryukov 14 years ago.
Updated for latest (current) trunk version of git-ified WP Core.
Use of AI Tools
None
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.