Skip to content

Build/test tools: copy the local environment configuration synchronously #12697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lancewillett wants to merge 3 commits into
base: trunk
Choose a base branch
from
+5 −3
Open

Build/test tools: copy the local environment configuration synchronously #12697

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f954bf1
Build/Test Tools: Copy the local environment configuration synchronou…
lancewillett Jul 26, 2026
7354d89
Merge branch 'trunk' into fix/env-start-env-copy-race
sirreal Jul 27, 2026
7889f14
Merge branch 'trunk' into fix/env-start-env-copy-race
lancewillett Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions tools/local-env/scripts/start.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,14 @@ const dotenv = require( 'dotenv' );
const dotenvExpand = require( 'dotenv-expand' );
const { execSync, spawnSync } = require( 'child_process' );
const local_env_utils = require( './utils' );
const { constants, copyFile } = require( 'node:fs' );
const { constants, copyFileSync } = require( 'node:fs' );

// Copy the default .env file when one is not present.
copyFile( '.env.example', '.env', constants.COPYFILE_EXCL, () => {
try {
copyFileSync( '.env.example', '.env', constants.COPYFILE_EXCL );
} catch ( e ) {
console.log( '.env file already exists. .env.example was not copied.' );
});
}
Comment on lines +10 to +14

@sirreal sirreal Jul 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good feedback. A better approach is probably to check whether the file already exists at the destination and copy if it doesn't, the try/catch should be safe to remove then, any errors that surface are useful information.


dotenvExpand.expand( dotenv.config() );

Expand Down
Loading