Skip to content

Media: Remove obsolete Flash fallback message from MediaElement l10n strings #12727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
irozum wants to merge 2 commits into
base: trunk
Choose a base branch
from
+17 −1
Open

Media: Remove obsolete Flash fallback message from MediaElement l10n strings #12727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
517f175
Media: Add test asserting MediaElement l10n omits the Flash message
irozum Jul 28, 2026
eb70edf
Media: Remove obsolete Flash fallback message from MediaElement l10n …
irozum Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/wp-includes/script-loader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1099,7 +1099,6 @@ function wp_default_scripts( $scripts ) {
'language' => strtolower( strtok( determine_locale(), '_-' ) ),
'strings' => array(
'mejs.download-file' => __( 'Download File' ),
'mejs.install-flash' => __( 'You are using a browser that does not have Flash player enabled or installed. Please turn on your Flash player plugin or download the latest version from https://get.adobe.com/flashplayer/' ),
'mejs.fullscreen' => __( 'Fullscreen' ),
'mejs.play' => __( 'Play' ),
'mejs.pause' => __( 'Pause' ),
Expand Down
17 changes: 17 additions & 0 deletions tests/phpunit/tests/dependencies/scripts.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1776,6 +1776,23 @@ public function test_priority_of_dependency_for_non_enqueued_dependent() {
);
}

/**
* Tests that the obsolete Flash-related MediaElement.js string is no longer localized.
*
* @ticket 65737
*
* @covers ::wp_default_scripts
*/
public function test_mediaelement_l10n_does_not_include_flash_message() {

@westonruter westonruter Jul 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, we don't need to add a test for this.

$wp_scripts = wp_scripts();
wp_default_scripts( $wp_scripts );

$inline_script = implode( '', (array) $wp_scripts->get_data( 'mediaelement-core', 'before' ) );

$this->assertStringNotContainsString( 'mejs.install-flash', $inline_script );
$this->assertStringContainsString( 'mejs.play', $inline_script );
Comment on lines +1789 to +1793
}

/**
* Tests that printing a script without enqueueing has the same output as when it is enqueued.
*
Expand Down
Loading