Image editor: fatal error when attachment metadata has no `sizes` array by josephscott · Pull Request #12744 · WordPress/wordpress-develop

josephscott · 2026-07-28T20:14:38Z

https://core.trac.wordpress.org/ticket/65748

AI assistance: Yes
Tool(s): Claude
Model(s): Opus 5
Used for: Writing the tests

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

https://core.trac.wordpress.org/ticket/65748

github-actions · 2026-07-28T20:16:47Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @nazmulasif.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props josephscott, westonruter, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copilot

Pull request overview

Fixes a fatal error path in the image editor when an attachment’s metadata lacks a usable sizes array, ensuring wp_save_image() / wp_restore_image() can proceed without type errors and adding regression coverage in the Ajax image editor test suite.

Changes:

Normalize $meta['sizes'] to an array in wp_save_image() before it’s passed to array_merge().
Normalize $meta and $meta['sizes'] in wp_restore_image() to avoid “Cannot use a scalar value as an array” fatals.
Add PHPUnit data-driven tests covering missing / scalar / null sizes metadata during save and restore flows.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
`tests/phpunit/tests/ajax/wpAjaxImageEditor.php`	Adds regression tests (data provider + two test methods) to ensure saving/restoring doesn’t fatal when `sizes` metadata is missing or invalid.
`src/wp-admin/includes/image-edit.php`	Hardens `wp_save_image()` and `wp_restore_image()` against missing/non-array `sizes` metadata.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+	if ( ! is_array( $meta ) ) {
+		$meta = array();
+	}
+
+	if ( ! isset( $meta['sizes'] ) || ! is_array( $meta['sizes'] ) ) {
+		$meta['sizes'] = array();
+	}


github-actions · 2026-07-28T20:19:32Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

westonruter · 2026-07-28T20:56:47Z

+	 * @return array[]
+	 */
+	public function data_save_image_with_unusable_sizes_metadata() {


Suggested change

* @return array[]

*/

public function data_save_image_with_unusable_sizes_metadata() {

* @return array<non-empty-string, array{ 0: array{ sizes?: mixed } }>

*/

public function data_save_image_with_unusable_sizes_metadata(): array {

westonruter · 2026-07-28T20:57:04Z

+	 *
+	 * @covers ::wp_restore_image
+	 */
+	public function test_restore_image_with_unusable_sizes_metadata( $meta ) {


Suggested change

public function test_restore_image_with_unusable_sizes_metadata( $meta ) {

public function test_restore_image_with_unusable_sizes_metadata( array $meta ) {

westonruter · 2026-07-28T20:57:12Z

+	 *
+	 * @covers ::wp_save_image
+	 */
+	public function test_save_image_with_unusable_sizes_metadata( $meta ) {


Suggested change

public function test_save_image_with_unusable_sizes_metadata( $meta ) {

public function test_save_image_with_unusable_sizes_metadata( array $meta ) {

mukeshpanchal27 · 2026-07-29T05:23:20Z

+	 * @ticket 65748
+	 *
+	 * @dataProvider data_save_image_with_unusable_sizes_metadata
+	 *
+	 * @param array $meta Attachment metadata to store before editing, minus the file-specific keys.
+	 *
+	 * @covers ::wp_save_image


Suggested change

* @ticket 65748

*

* @dataProvider data_save_image_with_unusable_sizes_metadata

*

* @param array $meta Attachment metadata to store before editing, minus the file-specific keys.

*

* @covers ::wp_save_image

* @ticket 65748

*

* @covers ::wp_save_image

*

* @dataProvider data_save_image_with_unusable_sizes_metadata

*

* @param array $meta Attachment metadata to store before editing, minus the file-specific keys.

mukeshpanchal27 · 2026-07-29T05:23:41Z

+	 * @ticket 65748
+	 *
+	 * @dataProvider data_save_image_with_unusable_sizes_metadata
+	 *
+	 * @param array $meta Replacement `sizes` metadata to store before restoring.
+	 *
+	 * @covers ::wp_restore_image


Suggested change

* @ticket 65748

*

* @dataProvider data_save_image_with_unusable_sizes_metadata

*

* @param array $meta Replacement `sizes` metadata to store before restoring.

*

* @covers ::wp_restore_image

* @ticket 65748

*

* @covers ::wp_restore_image

*

* @dataProvider data_save_image_with_unusable_sizes_metadata

*

* @param array $meta Replacement `sizes` metadata to store before restoring.

nazmulasif · 2026-07-29T07:52:14Z

Test Report

Patch tested: #12744

Environment

WordPress: 7.1-beta3-20260728.201755
Subdirectory: No
PHP: 7.4.33
Server: PHP.wasm
Database: WP_SQLite_Driver (Server: 8.0.38 / Client: 3.51.0)
Browser: Chrome 150.0.0.0
OS: macOS
Theme: Twenty Twenty-Five 1.5
MU Plugins: None activated
Plugins:
- Test Reports 1.3.0

Steps taken

Launched the WordPress Playground instance built from PR Image editor: fatal error when attachment metadata has no sizes array #12744.
Navigated to Media → Library and uploaded a test image.
Clicked Edit Image to open the core image editor interface.
Performed Crop and Scale operations, then saved the modifications.
Clicked Restore Original Image to revert the image back to its original state.
Verified that no PHP fatal errors or warnings occurred during the process.
✅ Patch is solving the problem

Expected result

Image saving, cropping, scaling, and restoring operations should execute successfully without throwing PHP type errors or fatal errors when processing attachment metadata.

Additional Notes

Tested via WordPress Playground instance. Crop, scale, and restore functionalities work as expected without any errors.

Screenshots/Screencast with results

Screenshot/Screencast before: N/A
Screenshot/Screencast after: N/A

Support Content

PR URL: Image editor: fatal error when attachment metadata has no sizes array #12744
Trac Ticket: https://core.trac.wordpress.org/ticket/65748

Image editor: fatal error when attachment metadata has no sizes array

877a4b0

https://core.trac.wordpress.org/ticket/65748

Copilot AI review requested due to automatic review settings July 28, 2026 20:14

Copilot started reviewing on behalf of josephscott July 28, 2026 20:17 View session

Copilot AI reviewed Jul 28, 2026

View reviewed changes

Comment thread src/wp-admin/includes/image-edit.php

Comment on lines +828 to +834

if ( ! is_array( $meta ) ) {

$meta = array();

}

if ( ! isset( $meta['sizes'] ) || ! is_array( $meta['sizes'] ) ) {

$meta['sizes'] = array();

}

westonruter reviewed Jul 28, 2026

View reviewed changes

Comment thread tests/phpunit/tests/ajax/wpAjaxImageEditor.php

westonruter reviewed Jul 28, 2026

View reviewed changes

mukeshpanchal27 reviewed Jul 29, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Image editor: fatal error when attachment metadata has no `sizes` array - #12744

Image editor: fatal error when attachment metadata has no `sizes` array#12744
josephscott wants to merge 1 commit into
WordPress:trunkfrom
josephscott:65748/image-edit-meta-sizes

josephscott commented Jul 28, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

Uh oh!

westonruter Jul 28, 2026

Uh oh!

westonruter Jul 28, 2026

Uh oh!

westonruter Jul 28, 2026

Uh oh!

mukeshpanchal27 Jul 29, 2026

Uh oh!

mukeshpanchal27 Jul 29, 2026

Uh oh!

nazmulasif commented Jul 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	public function test_restore_image_with_unusable_sizes_metadata( $meta ) {
	public function test_restore_image_with_unusable_sizes_metadata( array $meta ) {

	public function test_save_image_with_unusable_sizes_metadata( $meta ) {
	public function test_save_image_with_unusable_sizes_metadata( array $meta ) {

Uh oh!

Conversation

josephscott commented Jul 28, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unlinked Accounts

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

github-actions Bot commented Jul 28, 2026

Test using WordPress Playground

Some things to be aware of

Uh oh!

Uh oh!

westonruter Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

westonruter Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

westonruter Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

mukeshpanchal27 Jul 29, 2026

Choose a reason for hiding this comment

Uh oh!

mukeshpanchal27 Jul 29, 2026

Choose a reason for hiding this comment

Uh oh!

nazmulasif commented Jul 29, 2026

Test Report

Environment

Steps taken

Expected result

Additional Notes

Screenshots/Screencast with results

Support Content

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions Bot commented Jul 28, 2026 •

edited

Loading