fix(maven): preserve comments in pom.xml#294
Merged
TimothyJones merged 1 commit intoJul 18, 2026
Merged
Conversation
Comments may convey important information that needs retaining across bumps.
TimothyJones
changed the title
TimothyJones
enabled auto-merge (squash)
July 18, 2026 02:13
TimothyJones
disabled auto-merge
July 18, 2026 02:14
Member
|
Thanks for this! Nice catch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies the XML parser/builder config in the
mavenupdater in order to preserve comments across version bumps in thepom.xml. Comments may be conveying useful information that shouldn't be lost, and in the case of tools like renovate, they can themselves be a form of configuration.