Skip to content

Fix markdown syntax for external links#2431

Open
daniel-montalvo wants to merge 2 commits into
developfrom
fix-markdown-errors
Open

Fix markdown syntax for external links#2431
daniel-montalvo wants to merge 2 commits into
developfrom
fix-markdown-errors

Conversation

@daniel-montalvo

Copy link
Copy Markdown
Collaborator

Correct parentheses for markdown link urls.

Need for Call for Review: none (this is chore more than anything else)


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".
  • If your PR is for a new rule with an Accessibility Support note, or for updating the Accessibility Support note of an existing section, make sure to open a corresponding Accessibility Support issue.

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@daniel-montalvo daniel-montalvo self-assigned this Jul 22, 2026
@netlify

netlify Bot commented Jul 22, 2026

Copy link
Copy Markdown

Deploy Preview for act-rules ready!

Name Link
🔨 Latest commit 8083220
🔍 Latest deploy log https://app.netlify.com/projects/act-rules/deploys/6a61025a3d078400097b8818
😎 Deploy Preview https://deploy-preview-2431--act-rules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

[case folding]: https://www.w3.org/TR/charmod-norm/#dfn-case-folding
[element]: https://dom.spec.whatwg.org/#element
[normalization form KD]: https://www.unicode.org/glossary/#normalization_form_kd
[normalization form kd]: https://www.unicode.org/glossary/#normalization_form_kd

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm missing something but I'm not sure why you changed this line (and the corresponding line in the spelling yaml file) from the upper case "KD" to the lower case "kd". I think that it should be upper case. The Unicode spec uses upper case. The one usage site, on line 19 of this file, uses upper case.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind. I looked into it for a minute and I found that no other rule uses upper case in one of these "definition IDs", or whatever we're calling them. So I assume there's a reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants