Fix markdown syntax for external links#2431
Open
daniel-montalvo wants to merge 2 commits into
Open
Conversation
✅ Deploy Preview for act-rules ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dan-tripp-siteimprove
approved these changes
Jul 22, 2026
| [case folding]: https://www.w3.org/TR/charmod-norm/#dfn-case-folding | ||
| [element]: https://dom.spec.whatwg.org/#element | ||
| [normalization form KD]: https://www.unicode.org/glossary/#normalization_form_kd | ||
| [normalization form kd]: https://www.unicode.org/glossary/#normalization_form_kd |
Collaborator
There was a problem hiding this comment.
Maybe I'm missing something but I'm not sure why you changed this line (and the corresponding line in the spelling yaml file) from the upper case "KD" to the lower case "kd". I think that it should be upper case. The Unicode spec uses upper case. The one usage site, on line 19 of this file, uses upper case.
Collaborator
There was a problem hiding this comment.
Never mind. I looked into it for a minute and I found that no other rule uses upper case in one of these "definition IDs", or whatever we're calling them. So I assume there's a reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct parentheses for markdown link urls.
Need for Call for Review: none (this is chore more than anything else)
Pull Request Etiquette
When creating PR:
developbranch (left side).After creating PR:
Rule,DefinitionorChore.When merging a PR:
How to Review And Approve