ci: move argus to the aao secretariat app identity#34
Open
bokelley wants to merge 1 commit into
Open
Conversation
Argus now mints its App token from the org-level SECRETARIAT_APP_ID / SECRETARIAT_APP_PRIVATE_KEY secrets and posts reviews as aao-secretariat[bot] instead of the IPR App (aao-ipr-bot[bot]). The reviewer prompt drops the personal-voice identity clause: Argus is the review desk of the AAO Secretariat serving the AdCP Working Group, applies the WG constitution (fetched from adcontextprotocol/adcp@main at review time and appended to the prompt), and cites decision records (DR-NNNN in the spec repo's governance/decisions/) for settled precedent. Mirrors the spec repo migration in adcontextprotocol/adcp#5832. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
🛑 Argus paused on this PR. This PR modifies Argus's own configuration ( Automated by the Argus self-modification gate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Migrates the Argus AI-review workflow from the IPR GitHub App identity to the new AAO Secretariat GitHub App, mirroring the spec repo migration in adcontextprotocol/adcp#5832.
.github/workflows/ai-review.yml${{ secrets.SECRETARIAT_APP_ID }}/${{ secrets.SECRETARIAT_APP_PRIVATE_KEY }}instead ofIPR_APP_ID/IPR_APP_PRIVATE_KEY.https://raw.githubusercontent.com/adcontextprotocol/adcp/main/.agents/wg/constitution.md) and appends it to the reviewer prompt under a## WG constitution (from adcontextprotocol/adcp@main)heading — only when the fetch returns content. The constitution is never read from this repo or from the PR.git cat-file -echeck (checkout isfetch-depth: 0on the base SHA), so no change was needed there.app-slugoutput, so it follows the new App automatically (aao-secretariat[bot])..github/ai-review/expert-adcp-reviewer.mdDR-NNNNin the spec repo'sgovernance/decisions/) when a question is settled precedent. Repo-specific review logic (D-decision audits, MUST FIX bar, expert delegation) is untouched.ipr-agreement.yml, release/publish workflows, and sync-agent-roles are untouched.After merge
Argus reviews on this repo will post as
aao-secretariat[bot]instead ofaao-ipr-bot[bot].Do not merge until the org-level
SECRETARIAT_APP_ID/SECRETARIAT_APP_PRIVATE_KEYsecrets are visible to this repository, or Argus reviews will stop (token minting will fail on every PR).The WG constitution is fetched from
adcontextprotocol/adcp@mainat review time; if the fetch fails, the review proceeds without the constitution section rather than failing the run.Validation
python3 -c "import yaml;yaml.safe_load(open('.github/workflows/ai-review.yml'))"— passesbash -non the modified prompt-building shell block — passesnpx commitlint --from HEAD~1 --to HEADandscripts/check-pr-title.cjs— passNote: this PR touches Argus's own configuration, so the self-modification gate will pause Argus on it — a human review is required by design.
🤖 Generated with Claude Code