fix(compliance): replace hardcoded capability_id fixture value with field_present check#5845
Draft
bokelley wants to merge 1 commit into
Draft
fix(compliance): replace hardcoded capability_id fixture value with field_present check#5845bokelley wants to merge 1 commit into
bokelley wants to merge 1 commit into
Conversation
…ield_present check creative.supported_formats[].capability_id is an agent-local stable identifier with no protocol enum. The storyboard incorrectly asserted the fixture-specific value "training_image_generation", causing every creative agent with a different capability id to fail validation. Changed check: field_value (with hardcoded value) to check: field_present so the check validates structure rather than a fixture constant. Also removed the companion field_absent check on supported_formats[1].capability_id whose own description identified it as fixture-specific catalog shape. Closes #5843
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
canonical_supported_formatsstoryboard: thecapability_discoveryphase incorrectly asserted a fixture-specificcapability_idvalue ("training_image_generation") as a required protocol validation, causing every creative agent with a different — but equally valid — capability identifier to fail compliance.check: field_value(hardcoded"training_image_generation") tocheck: field_presentoncreative.supported_formats[0].capability_id, so the check validates structure rather than a fixture constant.field_absentcheck oncreative.supported_formats[1].capability_idwhose own description identified it as a fixture constraint ("only advertises implemented canonical build paths"), not a protocol requirement.creative.supported_formats[].capability_idis an agent-local stable identifier — a free-form string each creative agent defines independently. The protocol schema (get-adcp-capabilities-response.json) defines it with no enum constraint, and the storyboard narrative itself states it is "agent-local". The data flow fromcontext_outputsto$context.image_build_capability_idin the build phase is unaffected.Closes #5843
Test plan
canonical_supported_formatsstoryboard passes for a creative agent with anycapability_idvaluecanonical_supported_formatsstoryboard still correctly validates that acapability_idis present (structure check intact)canonical_supported_formatsstoryboard still validatesformat.format_kind: "image"(protocol-level assertion unchanged)image_build_capability_idis captured and consumed by the subsequent build phasepatchforadcontextprotocol)Generated by Claude Code