fix(compliance): use truthiness form in evaluator_auth skip_if guards#5846
Draft
bokelley wants to merge 2 commits into
Draft
fix(compliance): use truthiness form in evaluator_auth skip_if guards#5846bokelley wants to merge 2 commits into
bokelley wants to merge 2 commits into
Conversation
The adcp-client runner mishandles boolean false in != true comparisons: context.supports_evaluator evaluates to false but false != true is evaluated as false instead of true, causing evaluator phases to run against agents that do not advertise evaluator support. Replace all six skip_if guards from "context.supports_evaluator != true" to "!context.supports_evaluator" — semantically equivalent for booleans and consistent with the existing !context.build_capability_id / !context.creative_feature_id style already in the compound guards. The underlying runner bug is tracked separately in adcp-client. Closes #5844
Generated by tsc --project server/tsconfig.json; outDir is dist/, dist/compliance/ is explicitly un-ignored in .gitignore. File was added to server/src/compliance/ without its initial compiled output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applies a defensive storyboard workaround for an adcp-client runner bug that causes evaluator-specific phases to execute instead of being skipped for creative agents returning
creative.supports_evaluator: false.Root cause (adcp-client runner): When the captured context value is boolean
false, the runner'sskip_ifevaluator mishandles!= truestrict comparison — evaluatingfalse != trueasfalseinstead oftrue— so the guarded phase runs. The adcp-client bug should be tracked and fixed separately.Storyboard workaround: Changed all six
skip_ifguards from"context.supports_evaluator != true"to"!context.supports_evaluator"— semantically equivalent for boolean values and consistent with the truthiness style already used for!context.build_capability_idand!context.creative_feature_idin the compound guards throughout the same file.The storyboard was correctly authored per protocol semantics; this change is purely defensive during the 3.1 pre-release window.
Also includes initial committed build output for
dist/compliance/storyboard-runner-options.{js,d.ts}— compiled fromserver/src/compliance/storyboard-runner-options.tsviatsc --project server/tsconfig.json. Thedist/compliance/directory is explicitly un-ignored in.gitignore; these files were omitted from the initial source commit.Closes #5844
Test plan
evaluator_authstoryboard phases 2–6 are skipped when agent returnscreative.supports_evaluator: falseevaluator_authstoryboard phases 2–6 execute when agent returnscreative.supports_evaluator: true!= truepattern remains in anyskip_ifguard inevaluator_auth.yaml|| !context.build_capability_id || !context.creative_feature_id) skip correctly when any operand is falsypatchforadcontextprotocol)Generated by Claude Code