fix(cli): skip initial commit when git user.name or user.email is not set#285
Open
gonzoblasco wants to merge 1 commit into
Open
fix(cli): skip initial commit when git user.name or user.email is not set#285gonzoblasco wants to merge 1 commit into
gonzoblasco wants to merge 1 commit into
Conversation
… set Fixes akd-io#231 The CLI was crashing when trying to without git user.name or user.email configured. This happened because only checks for the existence of , not whether git identity is properly configured. Added helper that checks both and via . If either is missing, the initial commit step is skipped with a warning message instructing the user how to configure them.
|
@gonzoblasco is attempting to deploy a commit to the 9ty Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #231
The CLI was crashing when trying to run
git commit --amendwithoutgit user.nameoruser.emailconfigured. This happened becauseisGitInitializedonly checks for the existence of.git/, not whether git identity is properly set up.Why
Create Next App may succeed at initializing git (creating
.git/) but the subsequentgit commit --amendfrom CNS fails if the user hasn't configured their git identity. This is common in CI/CD environments and fresh setups.create-next-apphandles this gracefully, so CNS should too.How
hasGitUserConfighelper that checks bothuser.nameanduser.emailviagit configgit config user.name(without--global) so it works with both global and local configTesting
tsc --noEmitpassespnpm test:cli)isGitInitializedcheck