feat(telemetry): logout flow event#242
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 5 |
| Duplication | 0 |
TIP This summary will be updated as you push new changes.
- auth logout tracks CLI Auth Logout {flow: logout} before
auth.ClearToken(), while the user identifier is still attached to
the telemetry metadata
- no event when already signed out, and no Identify at logout time:
Segment's identity graph has no concept of un-identifying
- subsequent events already omit userId once the token is cleared
(Track/Identify only set the field when the metadata carries one)
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ff07592 to
9c4b5df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
GROUT-351 — logout telemetry flow. Stacked on #239 (
feat/auth-flow-events): it only needs the event catalog andTrackEventhelper from the auth step, nothing from the create/plan-change work.auth logoutemitsCLI Auth Logout(flow: logout) beforeauth.ClearToken(), while the user identifier is still attached to the telemetry metadata — the event is attributed to the user signing out.Identifyat logout time: Segment's identity graph has no concept of un-identifying — once ananonymousIdis aliased to auserId, the mapping persists by design.userId:Track/Identifyonly set the field when the metadata has one, and afterClearToken()the next invocations load no token. Events fall back toanonymousIdattribution, like a fresh install.Test
GROUT-351