feat(config): apply skip rules during the config.toml migration#247
Merged
Merged
Conversation
Before any keychain write, profiles go through the skip rules: - admin_api_key never moves to the new model; one log line points to ALGOLIA_ADMIN_API_KEY / --api-key instead. - No application_id or an empty api_key: nothing usable, skip + log. - Profiles sharing the same application_id: the default = true profile wins, the others are logged as conflicts and skipped. Profiles are processed in name order so conflict resolution and logs stay deterministic. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 15 |
| Duplication | 1 |
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Third step of GROUT-363, stacked on #246: the migration skip rules, applied before any keychain write.
admin_api_keynever moves to the new model: one log line points toALGOLIA_ADMIN_API_KEY/--api-keyinstead, whether the profile migrates or notapplication_idor with an emptyapi_keyhas nothing usable to migrate: skipped + logapplication_idwould overwrite each other's keychain entry: thedefault = trueprofile wins, the others are logged as conflicts and skippedConfiguredProfilesiterates a map)Test
GROUT-363