Fix dashboard underscore environment variable lookup#3631
Open
hutiefang76 wants to merge 1 commit into
Open
Conversation
a5e4afb to
83e37e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
The dashboard documentation uses underscore-style environment variables such as
sentinel_dashboard_auth_password, butDashboardConfigonly looked up the dotted key (sentinel.dashboard.auth.password).This adds an underscore environment variable fallback for dotted config names, while keeping the existing exact environment variable lookup and system property fallback order unchanged.
Does this pull request fix one issue?
Fixes #3543
Describe how you did it
When reading a config key from the environment,
DashboardConfignow:A unit test covers
sentinel_dashboard_auth_passwordresolving throughgetAuthPassword().Describe how to verify it
I verified the new behavior with
DashboardConfigTest:Result:
git diff --checkalso passed.Special notes for reviews
The local Maven/Surefire run selected the JUnit Platform provider because
spring-boot-starter-testbrings in JUnit Jupiter, but this test class is JUnit 4 and no Vintage engine is present. I usedJUnitCoredirectly so the existing JUnit 4 test class actually runs instead of reporting zero tests.