AKD-831: parameterise ALPINE_VERSION for the upstream, failing the bu…#53
Merged
Conversation
…ild if not present
crispy101
force-pushed
the
chore/AKD-381_bump_up_upstream
branch
2 times, most recently
from
c19bd49 to
b46e387
Compare
crispy101
force-pushed
the
chore/AKD-381_bump_up_upstream
branch
from
b46e387 to
04f0c8a
Compare
AdamJHall
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…st (empty) as default
Description of the proposed changes
specify apline version through env var instead of hardcoded value.
Screenshots (if applicable)
Other solutions considered (if any)
Notes to PR author
Notes to reviewers
php official docker repo offers
{PHP_VERSION}-alpine(the latest alpine), along with{PHP_VERSION}-alpine{ALPINE_VERSION}.Docker image build will fail if ALPINE_VERSION is not present, to avoid using the latest with regard to supply chain attack.ℹ️ When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback
Time Tracking
ABC-xxx: code review, select project XXXX