Skip to content

Config builder enhancements#217

Merged
amd-keonlee2 merged 6 commits into
developmentfrom
config_builder_enhancements
Jun 10, 2026
Merged

Config builder enhancements#217
amd-keonlee2 merged 6 commits into
developmentfrom
config_builder_enhancements

Conversation

@amd-keonlee2

@amd-keonlee2 amd-keonlee2 commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Fix where plugin argument default values would be set as default_factory() and downstream methods did not check this
  • Fix where dict and list objects would not be populated when generating a config
  • Modified test_config_builder.py to catch above case

Test plan

  • pytest test/unit
  • pytest test/functional (if applicable)
  • pre-commit run --all-files

Checklist

  • Added/updated tests (or explained why not)
  • Updated docs/README if behavior changed
  • No secrets or credentials committed

Before

    "KernelModulePlugin": {
      "collection": true,
      "analysis": true,
      "system_interaction_level": "INTERACTIVE",
      "data": null,
      "analysis_args": {
        "kernel_modules": null,
        "regex_filter": null
      }
    },
    "CmdlinePlugin": {
      "collection": true,
      "analysis": true,
      "system_interaction_level": "INTERACTIVE",
      "data": null,
      "analysis_args": {
        "required_cmdline": null,
        "banned_cmdline": null,
        "os_overrides": null,
        "platform_overrides": null
      }
    }

After

    "KernelModulePlugin": {
      "collection": true,
      "analysis": true,
      "system_interaction_level": "INTERACTIVE",
      "data": null,
      "analysis_args": {
        "kernel_modules": {},
        "regex_filter": [
          "amd"
        ]
      }
    },
    "CmdlinePlugin": {
      "collection": true,
      "analysis": true,
      "system_interaction_level": "INTERACTIVE",
      "data": null,
      "analysis_args": {
        "required_cmdline": [],
        "banned_cmdline": [],
        "os_overrides": {},
        "platform_overrides": {}
      }
    }

@alexandraBara alexandraBara left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amd-keonlee2 amd-keonlee2 merged commit 18b391c into development Jun 10, 2026
6 checks passed
@amd-keonlee2 amd-keonlee2 deleted the config_builder_enhancements branch June 10, 2026 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants