Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions sqlparse/sql.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,11 @@ class NameAliasMixin:

def get_real_name(self):
"""Returns the real name (object name) of this identifier."""
# a.b
dot_idx, _ = self.token_next_by(m=(T.Punctuation, '.'))
# a.b.c -> real name is the component after the *last* dot
dot_idx = None
for idx, tok in enumerate(self.tokens):
if tok.match(T.Punctuation, '.'):
dot_idx = idx
return self._get_first_name(dot_idx, real_name=True)

def get_alias(self):
Expand Down
18 changes: 18 additions & 0 deletions tests/test_parse.py
Original file line number Diff line number Diff line change
Expand Up @@ -466,6 +466,24 @@ def test_get_real_name():
assert 't' == stmts[0].tokens[2].get_alias()


def test_get_real_name_multi_part_dotted():
# issue 332: for a fully-qualified name the real name is the component
# after the *last* dot, not an intermediate one.
ident = sqlparse.parse("db.schema.tbl.col")[0].tokens[0]
assert 'col' == ident.get_real_name()
assert 'col' == ident.get_name()
# the parent object still anchors on the first dot
assert 'db' == ident.get_parent_name()

aliased = sqlparse.parse("x.y.z AS w")[0].tokens[0]
assert 'z' == aliased.get_real_name()
assert 'w' == aliased.get_alias()

# two-part names and function calls stay correct
assert 'b' == sqlparse.parse("a.b")[0].tokens[0].get_real_name()
assert 'func' == sqlparse.parse("mydb.sch.func(1)")[0].tokens[0].get_real_name()


def test_from_subquery():
# issue 446
s = 'from(select 1)'
Expand Down