Skip to content

fix(material/schematics): resolve issues in navigation schematic - #33590

Merged
crisbeto merged 1 commit into
angular:mainfrom
crisbeto:33381/navigation-schematic
Jul 28, 2026
Merged

fix(material/schematics): resolve issues in navigation schematic#33590
crisbeto merged 1 commit into
angular:mainfrom
crisbeto:33381/navigation-schematic

Conversation

@crisbeto

Copy link
Copy Markdown
Member

Resolves the following issues in the navigation schematic:

  1. We were using observables instead of signals for isHandset.
  2. We were using color on the toolbar.
  3. One of the standalone checks in the generated test was flipped.

Fixes #33381.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jul 28, 2026
@pullapprove
pullapprove Bot requested review from andrewseguin and tjshiu July 28, 2026 07:57
Resolves the following issues in the navigation schematic:
1. We were using observables instead of signals for `isHandset`.
2. We were using `color` on the toolbar.
3. One of the `standalone` checks in the generated test was flipped.

Fixes angular#33381.
@crisbeto
crisbeto force-pushed the 33381/navigation-schematic branch from 4a3b1db to fe2fc3d Compare July 28, 2026 07:59
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jul 28, 2026
@crisbeto
crisbeto merged commit 7f8a729 into angular:main Jul 28, 2026
30 of 32 checks passed
@crisbeto

Copy link
Copy Markdown
Member Author

This PR was merged into the repository. The changes were merged into the following branches:

crisbeto added a commit that referenced this pull request Jul 28, 2026
)

Resolves the following issues in the navigation schematic:
1. We were using observables instead of signals for `isHandset`.
2. We were using `color` on the toolbar.
3. One of the `standalone` checks in the generated test was flipped.

Fixes #33381.

(cherry picked from commit 7f8a729)
crisbeto added a commit that referenced this pull request Jul 28, 2026
)

Resolves the following issues in the navigation schematic:
1. We were using observables instead of signals for `isHandset`.
2. We were using `color` on the toolbar.
3. One of the `standalone` checks in the generated test was flipped.

Fixes #33381.

(cherry picked from commit 7f8a729)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(Navigation schematic): Several issues in the code generated by the navigation schematic

2 participants