Reject consecutive dots in Dag and task IDs in the Task SDK - #70630
Open
Andrushika wants to merge 1 commit into
Open
Reject consecutive dots in Dag and task IDs in the Task SDK#70630Andrushika wants to merge 1 commit into
Andrushika wants to merge 1 commit into
Conversation
apache#63296 added a check that blocks `..` in IDs to prevent path traversal in airflow.utils.helpers.validate_key, gated by [core] allow_double_dot_in_ids. Dag and task authoring now use the Task SDK validate_key, which never got that check, so IDs like a..b are accepted even when the flag is off. Add the same check to the Task SDK validator so the two validators agree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject consecutive dots in Dag and task IDs in the Task SDK
Why
validate_keyin the Task SDK does not block..in Dag and task IDs. SoDAG("a..b")andBaseOperator(task_id="a..b")are accepted, even when[core] allow_double_dot_in_idsis off. Core'svalidate_keyalready blocks this (added in #63296) to prevent path traversal, but the Task SDK has its own copy that never got the check.What
This adds the same check to the Task SDK
validate_key, using the sameallow_double_dot_in_idsflag and default. Both validators now behave the same.This issue was reported to the security team, which confirmed that there are no additional security concerns.
related: #63296
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Opus 4.8 following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.