Revert DMS provision checks to __init__ with is not None polarity - #70634
Merged
Conversation
o-nikolas
approved these changes
Jul 30, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves template_field validation back to
__init__fromexecute()for theDmsModifyTaskOperatorandDmsStartReplicationOperatoroperators in the providers/amazon/src/airflow/providers/amazon/aws/operators/dms.py file.The check is updated to use
is not Nonepolarity rather than a truthiness check, so this is not a straight revert of the original code.These are pure provision checks ("was this argument passed?") which belong in
__init__per the updated guidance in #70296, as moving them to execute() risks false positives whenrender_template_as_native_obj=Truerenders a provided field to None.Tests
related: #70296 and #70503
Was generative AI tooling used to co-author this PR?
Generated-by: [Antigravity IDE & Claude Web] following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.