Skip to content

Support require_approval in LLMBranchOperator - #70651

Open
guan404ming wants to merge 1 commit into
apache:mainfrom
guan404ming:llm-branch-require-approval
Open

Support require_approval in LLMBranchOperator#70651
guan404ming wants to merge 1 commit into
apache:mainfrom
guan404ming:llm-branch-require-approval

Conversation

@guan404ming

@guan404ming guan404ming commented Jul 28, 2026

Copy link
Copy Markdown
Member

Why

  • require_approval=True was rejected on LLMBranchOperator; this implements it.
  • Branching skips tasks irreversibly, so worth a human gate.

How

  • Pause for HITL review; run do_branch only after approval.
  • Validate reviewer-modified branches against downstream task IDs.
  • Reject non-string prompts with require_approval before agent runs.

E2E verified in breeze: pause, modified approval, correct skip.


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Fable 5)

Generated-by: Claude Code (Fable 5) following the guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant