Bump jsonpickle upper bound.#38769
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the jsonpickle dependency to allow versions up to 5.0.0. To accommodate the breaking change in jsonpickle 4.0.0, which introduced a more secure default decoding mode, the changes include logic to conditionally toggle the 'safe' decoding flag based on the pipeline's compatibility version. This ensures that existing artifacts remain readable while adopting secure defaults for newer pipelines. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates MLTransform to conditionally decode attributes securely using jsonpickle's safe parameter, falling back to the older behavior (allowing eval-based decoding) for compatibility with pipelines pinned to versions prior to 2.75.0. It also bumps the upper bound of the jsonpickle dependency to <5.0.0 and adds corresponding unit tests. The review feedback correctly points out that because jsonpickle < 4.0.0 is still supported, calling jsonpickle.decode with the safe keyword argument will raise a TypeError on older versions. It is recommended to conditionally pass this argument in both the main code and the tests by inspecting the function signature.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Assigning reviewers: R: @shunping for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Reminder, please take a look at this pr: @shunping |
Bump jsonpickle upper bound.
Version 4.0.0 + Uses
decode(safe=True)by default which avoids eval during decoding, which is a breaking change.https://github.com/jsonpickle/jsonpickle/blob/c3fa14e6c4a1099f7d1c8b0898b6bbf8aade5143/CHANGES.rst#v400.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.