Implement Spark SQL parser extensions and enhance analytic functions#38870
Draft
damccorm wants to merge 1 commit into
Draft
Implement Spark SQL parser extensions and enhance analytic functions#38870damccorm wants to merge 1 commit into
damccorm wants to merge 1 commit into
Conversation
211ee94 to
e78d80c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings in several enhancements for analytic/window functions and adds Spark-compatible SQL parser extensions:
CUME_DIST().IGNORE NULLSrouting forFIRST_VALUEandLAST_VALUE(needed for pandasffill/bfillcompatibility).ValueHolderaccumulator in these combiners to safely handle null values without throwing NPEs.BeamWindowRelto support functions with no input columns (likeCOUNT(*)).BeamWindowRuleby explicitly converting the input toBEAM_LOGICALconvention (mirrors what we do in Sort/Aggregation rules).parserImpls.ftlandconfig.fmpp: support for angle-bracket types (e.g.,array<int>,map<string, int>), type constructors (e.g.,float(x)), and the::infix cast operator.ARRAY(...)andMAP(...)function-form constructors inCalciteQueryPlannerso they validate correctly (bracket formARRAY[...]is standard, but function form is Spark-specific).BeamSqlDslArrayTestandBeamSqlMapTest.NanosDurationdecoding toBeamTableUtilsto correctly handle Calcite's interval representations.Added tests to
BeamAnalyticFunctionsTestforCUME_DISTandCOUNT(*) OVER ().