Fix VM migration with attached ISO

[hsato03]

Description

Using KVM, if a VM with an attached ISO is migrated to a host that does not have the path of that ISO mounted, but already has the libvirt storage pool corresponding to that ISO created, an exception is thrown. Therefore, it is not possible to migrate this VM.

Based on this, changes were made to ensure that the path of the ISO attached to the VM will be mounted during the migration.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

1. I deployed a VM on host A and attached an ISO to it;
2. I migrated this VM to host B;
3. I unmounted the ISO directory on host A;
4. I attempted to migrate the VM to host A.

Without the changes: an error occurred stating that it was not possible to mount the ISO's storage pool and the migration failed.

With the changes: the storage pool was mounted and the migration finished successfully.

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

❌ Patch coverage is 21.42857% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.10%. Comparing base (7308dad) to head (427e49c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
.../hypervisor/kvm/storage/LibvirtStorageAdaptor.java	21.42%	8 Missing and 3 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #13330      +/-   ##
============================================
- Coverage     18.10%   18.10%   -0.01%     
+ Complexity    16752    16751       -1     
============================================
  Files          6037     6037              
  Lines        542796   542806      +10     
  Branches      66456    66457       +1     
============================================
- Hits          98291    98278      -13     
- Misses       433460   433482      +22     
- Partials      11045    11046       +1     

Flag	Coverage Δ
uitests	3.51% <ø> (ø)
unittests	19.27% <21.42%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[hsato03]

@blueorangutan package

[blueorangutan]

@hsato03 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18138

[weizhouapache]

code lgtm

not tested

[weizhouapache]

@hsato03
can you rebase with 4.20 or 4.22 ?
both are supported LTS releases, refer to https://cwiki.apache.org/confluence/display/CLOUDSTACK/LTS

[hsato03]

@hsato03 can you rebase with 4.20 or 4.22 ? both are supported LTS releases, refer to https://cwiki.apache.org/confluence/display/CLOUDSTACK/LTS

Sure, I changed the base branch to 4.20.

[hsato03]

@blueorangutan package

[blueorangutan]

@hsato03 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18164

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-16316)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 50527 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13330-t16316-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[DaanHoogland]

clgtm