Fix ISO tagging tests: wait for ISO download before tagging operations#13368
Fix ISO tagging tests: wait for ISO download before tagging operations#13368awen11123 wants to merge 1 commit into
Conversation
The create_iso() helper in test_tags.py calls Iso.create() and immediately returns, but the ISO may still be downloading when tagging tests proceed. This causes tests 7, 16, and 17 to fail intermittently with upload errors. Call iso.download() after creation, which has a built-in retry loop that waits for the ISO to reach 'Successfully Installed' and isready state. If the download fails after the retry period, skip the test instead of failing with an opaque upload error. Fixes intermittent failures in test_07_iso_tag, test_16_query_tags_other_account, and test_17_query_tags_admin_account.
|
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
DaanHoogland
left a comment
There was a problem hiding this comment.
code looks good, just wonder if there is a chance for retry?
also would list not give an indication of FAIL?
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18264 |
|
@blueorangutan test |
|
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-16345)
|
🤖
Description
The
create_iso()helper intest/integration/component/test_tags.pycallsIso.create()and immediately returns, but the ISO may still be downloading when tagging tests proceed. This causes tests 7, 16, and 17 to fail intermittently when the ISO upload hasn't completed.This PR adds a call to
iso.download()after creation. Thedownload()method (on theIsoclass in marvin) already has a built-in retry loop (300 retries × 5s interval) that waits for the ISO to reachSuccessfully Installedandisreadystate.If the download fails after the retry period, the test is skipped with a clear message rather than failing with an opaque upload error.
Types of changes
Fixes
Fixes #7041
Affected tests
test_07_iso_tagtest_16_query_tags_other_accounttest_17_query_tags_admin_account