Enforce scheme checks for decoupled destinations#3266
Open
coheigea wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces an allowlist-based scheme check for WS-Addressing / WS-RM decoupled destinations (wsa:ReplyTo / wsa:FaultTo) to prevent CXF from opening outbound connections to attacker-controlled URIs, with an optional system-property override for operators.
Changes:
- Add
ContextUtils.isDecoupledDestinationAllowed(String)plus default allowed scheme prefixes and a system-property override. - Enforce the allowlist in decoupled backchannel creation paths (WS-Addressing impl, WS-RM internal context).
- Add protocol-level tests in both WS-Addressing and WS-RM modules to validate allowed/blocked schemes and override behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
core/src/main/java/org/apache/cxf/ws/addressing/ContextUtils.java |
Adds scheme allowlist + system-property override and applies it to ContextUtils.createDecoupledDestination() via a dedicated DecoupledDestination implementation. |
rt/ws/addr/src/main/java/org/apache/cxf/ws/addressing/impl/InternalContextUtils.java |
Enforces the scheme allowlist for decoupled backchannels and logs a warning when rejecting a disallowed destination. |
rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/InternalContextUtils.java |
Enforces the scheme allowlist for WS-RM decoupled destinations and adjusts helper visibility for testing. |
rt/ws/addr/src/test/java/org/apache/cxf/ws/addressing/impl/DecoupledDestinationProtocolTest.java |
Adds unit/protocol tests covering default allow/deny, override semantics, and ContextUtils decoupled-destination behavior. |
rt/ws/rm/src/test/java/org/apache/cxf/ws/rm/DecoupledDestinationProtocolTest.java |
Adds WS-RM focused protocol tests validating scheme enforcement and override behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
825d297 to
b142845
Compare
ffang
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.