Fill in missing utf8view support in function type coercion - #23916
Open
Jefffrey wants to merge 1 commit into
Open
Fill in missing utf8view support in function type coercion#23916Jefffrey wants to merge 1 commit into
Jefffrey wants to merge 1 commit into
Conversation
github-actions
Bot
added
logical-expr
Jefffrey
commented
Jul 27, 2026
| ( | ||
| Timestamp(TimeUnit::Nanosecond, None), | ||
| Null | Timestamp(_, None) | Date32 | Utf8 | LargeUtf8, | ||
| Null | Timestamp(_, None) | Date32 | Date64 | Utf8 | LargeUtf8 | Utf8View, |
Contributor
Author
There was a problem hiding this comment.
added date64 for the sake of it, since we already have date32 here
|
|
||
| # test with utf8view | ||
| query P | ||
| SELECT DATE_BIN(arrow_cast('5 month', 'Utf8View'), '2022-01-01T00:00:00Z'); |
Contributor
Author
There was a problem hiding this comment.
this was failing on main before, just an example of what this fix can affect
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23916 +/- ##
==========================================
- Coverage 80.67% 80.66% -0.01%
==========================================
Files 1094 1095 +1
Lines 371770 372293 +523
Branches 371770 372293 +523
==========================================
+ Hits 299907 300305 +398
- Misses 53964 54067 +103
- Partials 17899 17921 +22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Fill in some missing support for utf8view (and date64) in function type coercion. Main affected functions are UDFs that use exact/uniform type signature; for example in
date_binit couldnt coerce utf8view to its input types (even though utf8 worked)What changes are included in this PR?
Add support for casting to/from utf8view in some arms.
Are these changes tested?
Yes
Are there any user-facing changes?
No