fix: select Spring 6 REST adapter for samples#1297
Open
SavitarC wants to merge 1 commit into
Open
Conversation
SavitarC
marked this pull request as ready for review
July 26, 2026 10:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
dubbo-rest-spring6Maven profile to the Spring MVC Triple REST sample-Ddubbo.rest.spring6=true, explicitly select:dubbo-spring-boot-3-autoconfiguredubbo-rest-spring6Why
apache/dubbo#16394 separates the Spring 5 and Spring 6 REST adapters and removes the legacy
dubbo-rest-springimplementation from the aggregatedubboJAR.These Spring Boot 3 samples use Spring MVC mappings, so they must explicitly choose the Spring 6 / Jakarta adapter when tested against the candidate Dubbo build.
Compatibility
The profile is disabled by default. Normal sample builds therefore remain compatible with the current released Dubbo baseline, which does not provide
dubbo-rest-spring6.After a Dubbo release containing
dubbo-rest-spring6becomes the samples baseline, these dependencies can become unconditional and the temporary activation property can be removed.The profile selects only
dubbo-rest-spring6; it does not add the legacydubbo-rest-springadapter.Validation
With apache/dubbo#16394 at
ea51d470b1and-Ddubbo.version=3.3.7-SNAPSHOT -Dspring.version=6.1.5 -Ddubbo.rest.spring6=true:dubbo-spring-boot-3-autoconfigureanddubbo-rest-spring6, with no legacy adapterConsumerITtests passedResourceServerITtests passed/demo/helloreturns404 Invoker not founddubbo-rest-spring6git diff --checkpassedCI coordination
This PR depends on the new artifact from apache/dubbo#16394. Conversely, the samples workflow in apache/dubbo#16394 currently checks out
dubbo-samples@masterand does not enable this opt-in profile. Merging this PR unchanged by itself therefore does not make the core PR's samples checks green; the cross-repository ref/profile activation or merge sequence must be coordinated separately.Related