Skip to content

GROOVY-12199: Replace ant-jarjar with com.gradleup.shadow for package relocation#2740

Open
daniellansun wants to merge 1 commit into
masterfrom
GROOVY-12199
Open

GROOVY-12199: Replace ant-jarjar with com.gradleup.shadow for package relocation#2740
daniellansun wants to merge 1 commit into
masterfrom
GROOVY-12199

Conversation

@daniellansun

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: 64dd99f Previous: 19db4fd Ratio
org.apache.groovy.bench.ClosurePackBench.squared_mega ( {"pack":"false"} ) 7731.501912477089 ops/ms 3652.5510389057754 ops/ms 2.12
org.apache.groovy.bench.ClosurePackBench.squared_mega ( {"pack":"true"} ) 5676.25637344206 ops/ms 2729.7364545730643 ops/ms 2.08
org.apache.groovy.bench.ClosurePackBench.sum_mega ( {"pack":"false"} ) 2848.793613840976 ops/ms 1760.7556693094677 ops/ms 1.62
org.apache.groovy.bench.ClosurePackBench.sum_mono ( {"pack":"false"} ) 3972.797217298825 ops/ms 2487.5988659470463 ops/ms 1.60
org.apache.groovy.bench.dispatch.CallsiteBench.dispatch_3_polymorphic_java 5309.357355269179 ops/ms 1943.0968352805533 ops/ms 2.73
org.apache.groovy.bench.dispatch.CallsiteBench.dispatch_8_megamorphic_java 5144.873246697545 ops/ms 1515.8682443385032 ops/ms 3.39
org.apache.groovy.bench.AryBench.groovy ( {"n":"100"} ) 0.017247842654131946 ms/op 0.01145276953446965 ms/op 1.51
org.apache.groovy.bench.AryBench.groovy ( {"n":"1000000"} ) 297.67231599999997 ms/op 118.68991866653593 ms/op 2.51
org.apache.groovy.bench.AryBench.groovyCS ( {"n":"1000000"} ) 296.9195985428572 ms/op 115.96355100716373 ms/op 2.56
org.apache.groovy.bench.AryBench.java ( {"n":"1000000"} ) 294.2539245178572 ms/op 123.24462036708333 ms/op 2.39
org.apache.groovy.bench.CalibrationBench.allocationChurn 116.69430034174879 us/op 58.55344552992842 us/op 1.99

This comment was automatically generated by workflow using github-action-benchmark.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.8656%. Comparing base (a2ff978) to head (64dd99f).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##               master      #2740        +/-   ##
==================================================
- Coverage     69.8702%   69.8656%   -0.0046%     
+ Complexity      35139      35138         -1     
==================================================
  Files            1554       1554                
  Lines          130731     130731                
  Branches        23916      23916                
==================================================
- Hits            91342      91336         -6     
- Misses          31144      31147         +3     
- Partials         8245       8248         +3     

see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud

Copy link
Copy Markdown

@daniellansun
daniellansun requested a review from paulk-asert July 26, 2026 11:10
@github-actions

Copy link
Copy Markdown
Contributor

JMH summary — classic (commit 4e1bee3)

Speedup vs trailing 90-day baseline on gh-pages. Higher = faster.
1.00 = in line with history. Per-benchmark ratio, geomean within group.
Time-per-op units inverted so direction is consistent. The calibrated
column divides out this runner's speed vs the baseline hardware, as
measured by Groovy-independent pure-Java ruler benchmarks.

Group Speedup Calibrated n
bench 1.072 × 1.002 × 92
core 1.047 × 1.080 × 77
grails 0.957 × 0.909 × 80

Runner calibration (this run vs baseline hardware): bench 1.07× (26 rulers) · core-ag 0.97× (3 rulers) · core-hz 0.97× (3 rulers) · grails-ad 0.97× (3 rulers) · grails-ez 1.13× (3 rulers)

Baseline: dev/bench/jmh/<part>/classic/data.js on gh-pages, trailing 90 days. Daily dashboard · Per-suite raw data

@github-actions

Copy link
Copy Markdown
Contributor

JMH summary — indy (commit 4e1bee3)

Speedup vs trailing 90-day baseline on gh-pages. Higher = faster.
1.00 = in line with history. Per-benchmark ratio, geomean within group.
Time-per-op units inverted so direction is consistent. The calibrated
column divides out this runner's speed vs the baseline hardware, as
measured by Groovy-independent pure-Java ruler benchmarks.

Group Speedup Calibrated n
bench 1.011 × 0.962 × 92
core 3.522 × 3.581 × 77
grails 2.159 × 2.101 × 80

Runner calibration (this run vs baseline hardware): bench 1.04× (26 rulers) · core-ag 1.00× (3 rulers) · core-hz 0.97× (3 rulers) · grails-ad 0.96× (3 rulers) · grails-ez 1.08× (3 rulers)

Baseline: dev/bench/jmh/<part>/indy/data.js on gh-pages, trailing 90 days. Daily dashboard · Per-suite raw data

@testlens-app

testlens-app Bot commented Jul 26, 2026

Copy link
Copy Markdown

✅ All tests passed ✅

🏷️ Commit: 64dd99f
▶️ Tests: 21404 executed
⚪️ Checks: 31/31 completed


Learn more about TestLens at testlens.app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants