HBASE-30217 Remove dead code getRegionId and isTemporaryDirectoryName…#8331
Open
liuxiaocs7 wants to merge 2 commits into
Open
HBASE-30217 Remove dead code getRegionId and isTemporaryDirectoryName…#8331liuxiaocs7 wants to merge 2 commits into
liuxiaocs7 wants to merge 2 commits into
Conversation
… in HRegionFileSystem
wchevreuil
approved these changes
Jun 10, 2026
Comment on lines
81
to
95
| /** | ||
| * Temporary subdirectory of the region directory used for merges. | ||
| * @deprecated Since 3.0.0, will be removed in 4.0.0. Merges now write directly to the merged | ||
| * region directory under the table dir since HBASE-26187. | ||
| */ | ||
| @Deprecated | ||
| public static final String REGION_MERGES_DIR = ".merges"; | ||
|
|
||
| /** Temporary subdirectory of the region directory used for splits. */ | ||
| /** | ||
| * Temporary subdirectory of the region directory used for splits. | ||
| * @deprecated Since 3.0.0, will be removed in 4.0.0. Splits now write directly to the daughter | ||
| * region directory under the table dir since HBASE-26187. | ||
| */ | ||
| @Deprecated | ||
| public static final String REGION_SPLITS_DIR = ".splits"; |
Contributor
There was a problem hiding this comment.
Do we really need to deprecate those rather than simply remove it? HRegionFileSystem is marked as InterfaceAudience.Private, so isn't intended for public use.
Member
Author
There was a problem hiding this comment.
Thanks for the comments, agree with your points, I've removed the two constants directly. The only usage was in TestHdfsSnapshotHRegion, which I've updated to use string literals with a comment explaining they represent legacy directories from before HBASE-26187.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… in HRegionFileSystem