HBASE-30221 FNFE may occur when executing hbase snapshot info --list-snapshots#8340
Open
guluo2016 wants to merge 2 commits into
Open
HBASE-30221 FNFE may occur when executing hbase snapshot info --list-snapshots#8340guluo2016 wants to merge 2 commits into
hbase snapshot info --list-snapshots#8340guluo2016 wants to merge 2 commits into
Conversation
Apache9
reviewed
Jun 12, 2026
| if (!fs.exists(snapshotDir)) { | ||
| return Collections.emptyList(); | ||
| } | ||
| FileStatus[] snapshots = fs.listStatus(snapshotDir, |
Contributor
There was a problem hiding this comment.
Is it possible to test whether snapshots is null or empty, so we can save on request to HDFS namenode?
Member
Author
There was a problem hiding this comment.
Good point, thanks.
I checked the code again and luckily found that CommonFSUtils.listStatus can handle this case directly, so let me update the code, thanks again.
Apache9
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details see: HBASE-30221