HBASE-30225 Performance degradation observed on ycsb reads benchmark after HBASE-2972#8353
Open
wchevreuil wants to merge 1 commit into
Open
HBASE-30225 Performance degradation observed on ycsb reads benchmark after HBASE-2972#8353wchevreuil wants to merge 1 commit into
wchevreuil wants to merge 1 commit into
Conversation
…after HBASE-2972 Change-Id: I63fdb4a5ea23a0b3815b8e955b22ce5faa020d71
Apache9
reviewed
Jun 13, 2026
Apache9
left a comment
Apache9
left a comment
Contributor
There was a problem hiding this comment.
Mind explaining more about the changes here? I do not fully get what you are trying to fix here...
| public BlockCacheKey(Path hfilePath, long offset, boolean isPrimaryReplica, BlockType blockType) { | ||
| this(hfilePath.getName(), hfilePath.getParent().getName(), | ||
| hfilePath.getParent().getParent().getName(), offset, isPrimaryReplica, blockType, | ||
| HFileArchiveUtil.isHFileArchived(hfilePath)); |
Contributor
There was a problem hiding this comment.
Why here we can use false directly?
| this.hfileName = HFILE_NAME_POOL.intern(hfileName); | ||
| this.regionName = (regionName != null) ? REGION_NAME_POOL.intern(regionName) : null; | ||
| this.cfName = (cfName != null) ? CF_NAME_POOL.intern(cfName) : null; | ||
| this.hfileName = hfileName; |
Contributor
There was a problem hiding this comment.
If we do not do intern here, why we still put the above 3 string pools in this class?
| */ | ||
| package org.apache.hadoop.hbase.io.hfile; | ||
|
|
||
| import org.apache.commons.lang3.mutable.MutableBoolean; |
Contributor
There was a problem hiding this comment.
Where do we use this import?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.