fix: reject malformed commit property integers - #843
Open
fallintoplace wants to merge 2 commits into
Open
Conversation
fallintoplace
force-pushed
the
fix/reject-partial-commit-property-integers
branch
from
July 25, 2026 15:28
f881c81 to
d30768c
Compare
fallintoplace
changed the title
fallintoplace
changed the title
evindj
approved these changes
Jul 25, 2026
wgtmac
reviewed
Jul 29, 2026
| int32_t parsed; | ||
| auto [ptr, ec] = std::from_chars(it->second.data(), | ||
| it->second.data() + it->second.size(), parsed); | ||
| const auto* end = it->second.data() + it->second.size(); |
Member
There was a problem hiding this comment.
I would suggest to replace it with StringUtils::ParseNumber<int32_t>.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integer.parseIntTesting
ctest --test-dir build -R ^table_test$ --output-on-failure