Load table credentials from credentials endpoint#3500
Draft
kevinjqliu wants to merge 1 commit into
Draft
Conversation
31e0af9 to
eddce8f
Compare
eddce8f to
0f80215
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/credentialsduring REST table response handling when inline credentials are absent.loadCredentialsandvended-credentialsaccess delegation is requested.storage-credentialsprecedence over catalog config./credentialsrequest for remote signing and catalogs that do not advertise the endpoint.Stacked on #3499.
Testing
PYTHONPATH=. pytest tests/catalog/test_rest.py -k 'load_credentials or storage_credentials or load_table_honor_access_delegation or load_table_without_storage_credentials'ruff check pyiceberg/catalog/rest/__init__.py tests/catalog/test_rest.pyruff format --check pyiceberg/catalog/rest/__init__.py tests/catalog/test_rest.pygit commit