GH-3505: Bump sis from 1.4 to 1.5#4015
Merged
Merged
Conversation
Member
|
Hi @ThomasThelen, Thank you for this PR and the changes of note. SIS 1.6 was recently released and it contains a security fix. If there isn't a reason not to, would be possible to update this PR to 1.6? I changed the POM declaration and it at least successfully built and run the tests with no changes other than version. |
Contributor
Author
|
Good call. I bumped the version and the new tests passed without issue. Thanks for taking a look! |
Member
|
Thank you! |
Member
|
Just FYI: Nothing to worry about. Merging this triggered a security alert on Derby. Its's automated. While Derby is only used for the development part of the project, not part of the release used in production, we try to stay current so security scans by downstream users are as clean as possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved #3505
Pull request Description:
This PR bumps the SIS version from 1.4 to 1.5. There are several small changes that came along with it.
Datumto anEnsemble,CRS:84being one of them. Rather than constructing the WKT string, we can now callCRS.forCode("CRS:84");As for new documentation... I don't think any of it needs to change unless the new
derbydependency changes anything.By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.
See the Apache Jena "Contributing" guide.