Centralize third-party dependency versions in the BOM#461
Open
ppkarwasz wants to merge 1 commit into
Open
Conversation
All third-party dependency versions now live in flume-third-party-dependencies, so there is a single source of truth. Previously flume-parent and flume-ng-node also declared versions (junit, mockito, hadoop test artifacts, mockserver, JUnit 5, etc.), some duplicating properties already defined in the BOM. The BOM dependencyManagement entries are now ordered by artifactId. Also drop the redundant relativePath (../pom.xml is the Maven default) and clarify the module description. Assisted-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All third-party dependency versions are now declared in a single place,
flume-third-party-dependencies(the BOM). Previouslyflume-parentandflume-ng-nodealso declared dependency versions directly, some of them duplicating properties already defined in the BOM.Changes
flume-third-party/pom.xmljunit,junit-jupiter-*/junit-vintage-engine,mockito-core,fest-reflect,system-rules,hadoop-minikdc,hadoop-mapreduce-client-core,apacheds-jdbm1,mockserver-netty,mockserver-client-java. The two previously hardcoded versions (2.0.0-M2,3.10.8) are now properties for consistency.dependencyManagemententries are ordered byartifactId.relativePath(../pom.xmlis the Maven default) and clarifies the module description (it is a BOM).flume-parent/pom.xml:dependencyManagementnow holds only internal Flume modules; removed the leaked entries and their now-unused properties, plus the deadwiremock.version. Thecurator/hadoop/system-rulesproperty duplication with the BOM is gone.flume-ng-node/pom.xml: removed the localjunit-jupiter.versionproperty and the three inline<version>tags; the JUnit 5 deps now inherit the version from the BOM.Verification
mvn validatepasses across the whole reactor.flume-ng-nodeconfirms the JUnit 5 artifacts resolve to5.12.2via managed dependencies.Note:
external.protobuf.versionstays influme-parentbecause it feeds theprotocArtifact(protoc compiler) config influme-file-channel, which inherits it through the parent chain (BOM properties do not propagate to modules).