Use the NPM dependencies from the gha/v0 branch#507
Draft
ppkarwasz wants to merge 2 commits into
Draft
Conversation
Replace the NPM dependencies with a single Git dependency on the `gha/v0` branch, where Dependabot keeps the dependencies of all Apache Logging websites up-to-date at once. Website deployments pass the new `npm-dependencies-ref` input to `deploy-site-reusable`, which downloads `package.json` and `package-lock.json` from that branch before building the website. Release website staging keeps using the `package.json` committed in the repository. Making website builds from released source archives reproducible will be addressed separately. Assisted-By: Claude Fable 5 <noreply@anthropic.com>
Prove that the centralized NPM dependencies work before #506 is merged. Revert this commit once the manifests are available on `gha/v0`. Assisted-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion of #506, which centralizes the NPM dependencies of all Apache Logging websites on the
gha/v0branch.package.jsonshrinks to a single Git dependency ongha/v0;package-lock.jsonis no longer committed.npm-dependencies-ref: gha/v0todeploy-site-reusable, so they build with the exact dependency tree from that branch. Release website staging keeps using the committedpackage.json.gha/v0branch only.Note
Requires #506 to be merged first, since the Git dependency and the download step point at files that only exist on
gha/v0after that merge.With these two PRs, our live staging and production website will always use the latest dependencies from the
gha/v0branch.The only gap remaining is how to handle site generation from the source archive. In practice none of our websites is build from the source archive, but users should be able to generate some documentation from those sources too.