Skip to content

Open files from imported projects on first run after update. #9464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neilcsmith-net wants to merge 1 commit into
base: master
Choose a base branch
from
+24 −1
Open

Open files from imported projects on first run after update. #9464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion ide/projectui/src/org/netbeans/modules/project/ui/OpenProjectList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
import java.util.logging.Level;
import java.util.logging.LogRecord;
import java.util.logging.Logger;
import java.util.prefs.Preferences;
import javax.swing.Icon;
import org.netbeans.api.annotations.common.NonNull;
import org.netbeans.api.annotations.common.NullAllowed;
Expand Down Expand Up @@ -428,15 +429,37 @@ private void updateGlobalState() {
}
});

INSTANCE.pchSupport.firePropertyChange(PROPERTY_OPEN_PROJECTS, new Project[0], lazilyOpenedProjects.toArray(new Project[0]));
Project[] opened = lazilyOpenedProjects.toArray(Project[]::new);
INSTANCE.pchSupport.firePropertyChange(PROPERTY_OPEN_PROJECTS, new Project[0], opened);
Project main = INSTANCE.mainProject;
if (main != null) { // else PROPERTY_MAIN_PROJECT would be fired spuriously
INSTANCE.pchSupport.firePropertyChange(PROPERTY_MAIN_PROJECT, null, main);
}

if (checkFirstRun() && opened.length > 0) {
Comment thread
mbien marked this conversation as resolved.
OPENING_RP.execute(() -> {
for (Project p : opened) {
Project del = p.getLookup().lookup(Project.class);
ProjectUtilities.openProjectFiles(del == null ? p : del);
}
});
}

log(Level.FINER, "updateGlobalState, done, notified"); // NOI18N
}

private boolean checkFirstRun() {
Preferences prefs = OpenProjectListSettings.getInstance().getPreferences();
String prefKey = "projectListVersion"; // NOI18N
String build = System.getProperty("netbeans.buildnumber", "0"); // NOI18N
if (!prefs.get(prefKey, "").equals(build)) {
prefs.put(prefKey, build);
return true;
} else {
return false;
}
}

boolean closeBeforeOpen(final Project[] arr) {
return OpenProjectList.MUTEX.writeAccess(new Mutex.Action<Boolean>() {
public @Override Boolean run() {
Expand Down
Loading