MINIFICPP-2862 Add StandardValidator::NUMBER_VALIDATOR by martinzink · Pull Request #2213 · apache/nifi-minifi-cpp

martinzink · 2026-07-09T07:42:52Z

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

For all changes:

Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?

For code changes:

If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE file?
If applicable, have you updated the NOTICE file?

For documentation related changes:

Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

Copilot

Pull request overview

Adds a new standard numeric property validator to MiNiFi C++ and updates the parsing utilities to support stricter floating-point parsing via std::from_chars, then wires the validator through the C API mappings and validates behavior with unit tests.

Changes:

Introduces StandardPropertyValidators::NUMBER_VALIDATOR and exposes it through the C API enum/mapping.
Replaces parseFloat with a templated parseFloatingPoint<T> implementation using std::from_chars.
Adds/updates property parsing helpers and a unit test covering numeric validation.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
minifi-api/include/minifi-api.h	Adds `MINIFI_VALIDATOR_NUMBER` to the C API validator enum.
minifi-api/common/include/minifi-cpp/core/PropertyValidator.h	Adds `NumberValidator` and exposes it as a standard validator; refactors validator classes.
libminifi/test/unit/PropertyValidationTests.cpp	Adds unit test coverage for the new number validator.
libminifi/src/minifi-api.cpp	Maps the new C API enum value to the C++ standard validator instance.
extension-framework/include/utils/ProcessorConfigUtils.h	Adds float parsing helpers and switches optional float parsing to `parseFloatingPoint<float>`.
extension-framework/cpp-extension-lib/src/utils/minifi-c-utils.cpp	Adds reverse-mapping from `NUMBER_VALIDATOR` to `MINIFI_VALIDATOR_NUMBER`.
extension-framework/cpp-extension-lib/include/api/utils/ProcessorConfigUtils.h	Switches optional float parsing to `parseFloatingPoint<float>`.
core-framework/common/src/utils/ParsingUtils.cpp	Removes the old `parseFloat` implementation.
core-framework/common/include/utils/ParsingUtils.h	Adds templated `parseFloatingPoint<T>` implementation using `std::from_chars`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

martinzink · 2026-07-09T08:22:25Z

+  const auto trimmed_input = utils::string::trim(input);
+  T value{};
+
+  const auto [ptr, ec] = std::from_chars(trimmed_input.data(), trimmed_input.data() + trimmed_input.size(), value);


Unlike other parsing functions in C++ and C libraries, std::from_chars is locale-independent, non-allocating, and non-throwing.

source: https://en.cppreference.com/cpp/utility/from_chars

fgerlits

LGTM, but do we want to implement NUMBER_VALIDATOR in Python, too, now that we can?

martinzink · 2026-07-09T09:36:56Z

LGTM, but do we want to implement NUMBER_VALIDATOR in Python, too, now that we can?

sure, good idea add NUMBER_VALIDATOR to python

szaszm · 2026-07-09T10:25:38Z

  }
  gsl_FailFast();


if we crash on unknown enum values, then adding another validator later can't be done without breaking API

yeah i hoped we can merge this in faster than the release 🤞

I think we could just fallback on ALWAYS_VALID, for c api extensions, the parsing happens on the extension side anyway

… but we would like to use them optionally we cant add this validator because it breaks the setting the value to "" to disable workflow

szaszm · 2026-07-09T12:51:29Z

I think I'd rather stop breaking the API now in preparation for a release, and add this feature in a future version.

martinzink · 2026-07-09T14:50:12Z

I converted this to draft since its an API breaking change which we would like to avoid for now.
Maybe we could add this to a branch with all of these small api breaking changes, which we can rebase until we decide to pull the trigger and bump the api

martinzink · 2026-07-09T15:03:12Z

I've retargeted the PR to api-bump branch, we can merge it if it comes to that then we can deal with the PRs collected there when we want to bump the api

szaszm

+1 for merging to the api_bump branch, I would just hold off of merging to main for now

MINIFICPP-2862 Add StandardValidator::NUMBER_VALIDATOR

63bc044

martinzink requested a review from Copilot July 9, 2026 07:42

Copilot started reviewing on behalf of martinzink July 9, 2026 07:43 View session

Copilot AI reviewed Jul 9, 2026

View reviewed changes

Comment thread extension-framework/include/utils/ProcessorConfigUtils.h Outdated

Comment thread minifi-api/common/include/minifi-cpp/core/PropertyValidator.h

Comment thread extension-framework/include/utils/ProcessorConfigUtils.h Outdated

martinzink added 2 commits July 9, 2026 09:51

review changes

778b8cd

add NUMBER_VALIDATOR to RunLlamaCppInference::Temperature,TopP,MinP

1e32884

martinzink requested review from adamdebreceni and szaszm July 9, 2026 08:13

martinzink commented Jul 9, 2026

View reviewed changes

adamdebreceni approved these changes Jul 9, 2026

View reviewed changes

fgerlits reviewed Jul 9, 2026

View reviewed changes

add NUMBER_VALIDATOR to python

754c075

martinzink requested a review from fgerlits July 9, 2026 10:15

lordgamez approved these changes Jul 9, 2026

View reviewed changes

szaszm reviewed Jul 9, 2026

View reviewed changes

since RunLlamaCppInference::Temperature and TopP have default values,…

8338baf

… but we would like to use them optionally we cant add this validator because it breaks the setting the value to "" to disable workflow

fgerlits reviewed Jul 9, 2026

View reviewed changes

Comment thread extensions/python/pythonprocessors/nifiapi/properties.py

martinzink marked this pull request as draft July 9, 2026 14:49

add PropertyValidatorCode::NUMBER

9a4750f

martinzink changed the base branch from main to api_bump July 9, 2026 14:56

martinzink added the c-api label Jul 9, 2026

martinzink marked this pull request as ready for review July 9, 2026 14:56

fgerlits approved these changes Jul 9, 2026

View reviewed changes

szaszm approved these changes Jul 10, 2026

View reviewed changes

update ubuntu_22_04_clang_arm_manifest.json

ce94bc4

martinzink merged commit e8e3298 into apache:api_bump Jul 15, 2026
7 checks passed

Uh oh!

Conversation

martinzink commented Jul 9, 2026

For all changes:

For code changes:

For documentation related changes:

Note:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

martinzink Jul 9, 2026

Choose a reason for hiding this comment

Uh oh!

fgerlits left a comment

Choose a reason for hiding this comment

Uh oh!

martinzink commented Jul 9, 2026

Uh oh!

szaszm Jul 9, 2026

Choose a reason for hiding this comment

Uh oh!

martinzink Jul 9, 2026

Choose a reason for hiding this comment

Uh oh!

adamdebreceni Jul 9, 2026

Choose a reason for hiding this comment

Uh oh!

szaszm commented Jul 9, 2026

Uh oh!

Uh oh!

martinzink commented Jul 9, 2026

Uh oh!

martinzink commented Jul 9, 2026

Uh oh!

szaszm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants