ORC-2178: [C++] Add basic RISC-V build system and CPU detection support#2639
Open
zhanchangbao-sanechips wants to merge 1 commit into
Open
ORC-2178: [C++] Add basic RISC-V build system and CPU detection support#2639zhanchangbao-sanechips wants to merge 1 commit into
zhanchangbao-sanechips wants to merge 1 commit into
Conversation
Member
|
Thanks for your interest in working on this! Before proceeding, I have some general questions:
|
Author
Thanks for your questions.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
add the minimum to get RISC-V support in the build system and CPU detection. This is needed before can start add RVV-optimization.
changes:
BUILD_ENABLE_RVVCMake option (off by default)ConfigSimdLevel.cmakeORC_USER_SIMD_LEVELnow accepts RVV or NONEIf RVV isn't available, it just falls back to scalar code.
Why are the changes needed?
ORC doesn't know anything about RISC-V. This is just the groundwork so follow-up patches can actually use RVV. (https://issues.apache.org/jira/browse/ORC-1971)
How was this patch tested?
-DBUILD_ENABLE_RVV=ON, config passedORC_USER_SIMD_LEVEL=NONEproperly masks out RVV