[flink] Fix source split reader release reliability#8183
Open
QuakeWang wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The source split readers keep a single pooled iterator and may also hold
currentFirstBatchafter seeking past restored records.The old design had two reliability gaps:
close()only closed the lazy record reader, so an already fetchedcurrentFirstBatchcould be left unreleased.releaseBatch()returned the pooled iterator only after the underlying batch release succeeded. Ifiterator.releaseBatch()threw, the single-entry pool lost its iterator and later fetches could block forever.This PR releases
currentFirstBatchduring close, always returns the pooled iterator in afinallyblock, and aligns the CDC reader's no-split fetch path with the common reader by failing clearly instead of returning without a valid split.Tests
mvn -pl paimon-flink/paimon-flink-common -am -Pfast-build -DfailIfNoTests=false -Dtest=FileStoreSourceSplitReaderTest testmvn -pl paimon-flink/paimon-flink-cdc -am -Pfast-build -DfailIfNoTests=false -Dtest=CDCSourceSplitReaderTest test