WW-5645 Harden static content path handling and remove redundant URL decode#1777
Open
arunmanni-ai wants to merge 7 commits into
Open
WW-5645 Harden static content path handling and remove redundant URL decode#1777arunmanni-ai wants to merge 7 commits into
arunmanni-ai wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
buildPath()method inDefaultStaticContentLoaderappliedURLDecoder.decode()to resource paths that the servlet containerhad already decoded. This redundant decode served no purpose and
conflicted with the servlet spec's path handling contract.
This patch:
URLDecoder.decode()call frombuildPath()Validator.containsMalformedPathSegment()utilitythat rejects dot-dot sequences, backslash separators, and
percent-encoded forms that have no place in normalised resource paths
RequestUtils.getServletPath()