TEZ-4476: Move tez-ui testing from PhantomJS to Headless Chrome#514
TEZ-4476: Move tez-ui testing from PhantomJS to Headless Chrome#514maheshrajus wants to merge 6 commits into
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
|
@abstractdog @ayushtkn |
|
thanks for this patch @maheshrajus, a few notes:
while it was awesome to see, I'm expecting a headless browser to not display at all, does it make sense?
|
|
@abstractdog Thank you for the review. |
@abstractdog Initially the changes related to headless present in my first commit. After that while fixing ui-tests it got overwritten. Let me fix and run locally and verify it. thanks ! |
|
(!) A patch to the testing environment has been detected. |
|
(!) A patch to the testing environment has been detected. |
|
(!) A patch to the testing environment has been detected. |
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
|
(!) A patch to the testing environment has been detected. |
|
🎊 +1 overall
This message was automatically generated. |
|
(!) A patch to the testing environment has been detected. |
@abstractdog Can we handle this in separate JIRA ? |
|
@abstractdog I fixed your review comments and verified locally + in yetus CI env. |
|
🎊 +1 overall
This message was automatically generated. |
looks good so far, I have only one concern: on a vanilla ubuntu server, when chromium wasn't installed, the build simply failed by: if the build process cannot take care of fetching a chrome or chromium, then a preinstalled chrome is a hard dependency of a |
@abstractdog Thank you for the review. I have not taken care of chromium, Let me check and fix it. |
|
(!) A patch to the testing environment has been detected. |
|
@abstractdog I have addressed your review comments and tested the changes in the environments listed below. Everything is working as expected. |
|
💔 -1 overall
This message was automatically generated. |
|
(!) A patch to the testing environment has been detected. |
|
🎊 +1 overall
This message was automatically generated. |
|
@abstractdog |
thanks @maheshrajus , tried it on a vanilla ubuntu, and doesn't seem to work as I expect, let me share what I can see and maybe you can tell if I miss something:
so I'm not sure anymore if mvn install automatically takes care of yarn install, or I have to do it, becuase even if I saw the echo message, it would tell "Alternatively, run 'yarn install' inside src/main/webapp to let puppeteer download Chromium automatically.", but doc says "# "yarn install" (run automatically by Maven) will download a bundled # Chromium, so the build works on a vanilla machine with no pre-installed" |
I checked it locally with ubuntu and worked for me. Let check it if i am missing anything over here. need to check if already yarn package installed in this vm or not. Let me check and run in freshly created vanilla ubuntu vm. thanks ! |

TEZ-4476: Move tez-ui testing from PhantomJS to Headless Chrome.
PhantomJS is no longer maintained and has known incompatibilities with
modern OpenSSL (3+). So better to Replace it with Headless Chrome.